nikic added a comment.
FYI I just noticed some i686 failures that look something like this:
/builddir/build/BUILD/llvm-16.0.0.src/redhat-linux-build/unittests/Option/./OptionTests
--gtest_filter=OptTableTest/0.FindNearest
--
/builddir/build/BUILD/llvm-16.0.0.src/unittests/Option/OptionParsingTest.cpp:314:
Failure
Expected equality of these values:
1U
Which is: 1
T.findNearest("-blorb", Nearest)
Which is: 4294967295
/builddir/build/BUILD/llvm-16.0.0.src/unittests/Option/OptionParsingTest.cpp:315:
Failure
Expected equality of these values:
Nearest
Which is: ""
"-blorp"
Plausibly caused by this change -- I'm thinking that `MaximumDistance` is
initialized to `UINT_MAX - 1`, but then we cast that to a signed integer and
compare that, so it wraps to a large negative number.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142026/new/
https://reviews.llvm.org/D142026
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
