majnemer added a comment. In https://reviews.llvm.org/D23086#507098, @Anastasia wrote:
> In https://reviews.llvm.org/D23086#507055, @majnemer wrote: > > > This approach seems wrong to me. > > > > Instead, why not just make `ndrange_t` a typedef of a real struct in > > `Sema::Initialize`? > > > I think we have an issue because in that case during the diagnostic of > enqueue_kernel Builtin in SemaChecking.cpp we won't have a good way to > identify this type apart from checking its name... That's OK, there are special types like this elsewhere (std::type_info from c++). That's why ideally we would like to leave it as a special Builtin type. > What kind of issues do you see with the current implementation? > > Also do you suggest to create the struct in Sema::Initialize? Alternatively, > we also have an OpenCL header file for such things. Repository: rL LLVM https://reviews.llvm.org/D23086 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
