fpetrogalli marked an inline comment as done. fpetrogalli added a comment. In D137517#4045299 <https://reviews.llvm.org/D137517#4045299>, @jrtc27 wrote:
> In D137517#4042875 <https://reviews.llvm.org/D137517#4042875>, @fpetrogalli > wrote: > >> In D137517#4042758 <https://reviews.llvm.org/D137517#4042758>, @fpetrogalli >> wrote: >> >>> After submitting this, I had to revert it >>> <https://github.com/llvm/llvm-project/commit/8bd65e535fb33bc48805bafed8217b16a853e158> >>> because of failures like >>> https://lab.llvm.org/buildbot/#/builders/225/builds/12367/steps/5/logs/stdio >> >> I have resubmitted with what I hope is the right fix (I could not reproduce >> any of the failures I was seeing in buildbot, on my machine the build is >> fine). >> >> The new commit is at >> https://github.com/llvm/llvm-project/commit/ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf >> - in the commit message I have explained what I have changed WRT this >> original patch. I have added the >> tablegen target `RISCVTargetParserTableGen` in the `DEPENDS` list of >> `clangDriver` and `clangBasic`. This makes sure that the `.*inc` file with >> theist o the CPU is available even if `LLVMTargetParser` has not been built >> yet. > > But you didn't use the proper Differential Revision tag, so the diff here > didn't get updated to reflect the amended version committed :( What should I have done? Add the `Differential Revision: https://reviews.llvm.org/D137517` as the last line of the commit with the rework? I wasn't aware of this for reworks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
