NoQ added a comment.

In D139737#4037455 <https://reviews.llvm.org/D139737#4037455>, @ziqingluo-90 
wrote:

> Since we do not have any `FixableGadget` to trigger fix-its at this point,  I 
> let fix-its of local variable declarations always be emitted for the purpose 
> of testing.

It sounds to me as if by landing the patch we'll temporarily make the compiler 
emit incorrect fixes. I think we should avoid doing that. Is it possible to 
wait until our first proof-of-concept `FixableGadget` lands before landing this 
patch? I think there shouldn't be too much conflict between such patches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139737/new/

https://reviews.llvm.org/D139737

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to