ymandel added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:89
+ ? DataflowAnalysisContext::Options{}
+ : llvm::Optional<DataflowAnalysisContext::Options>()}) {}
----------------
xazax.hun wrote:
> If we already change this code, I think we can consider replacing this with
> `std::optional` but feel free to ignore.
> If we already change this code, I think we can consider replacing this with
> `std::optional` but feel free to ignore.
Thanks, I was actually wondering about that. I wasn't sure where llvm/clang was
in terms of `std::optional` adoption. I'm happy to update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140703/new/
https://reviews.llvm.org/D140703
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
