nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

LGTM

> As a precaution, use LLVM_THREAD_LOCAL which provides even greater
> backwards compatibility, allowing this to function even pre-C++11
> versions of GCC.

I don't think backwards compatibility is still relevant given our minimum 
version requirements. We can probably drop the `__thread` fallback. What 
LLVM_THREAD_LOCAL does though is fall back to a normal variable if 
`!LLVM_ENABLE_THREADS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141349/new/

https://reviews.llvm.org/D141349

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to