carlosgalvezp added a comment. > Therefore does it make sense to also do the same with the IncludeStyle as > lots of checks add new includes.
Sure, that could also be done, though I think it'd be preferable to do it in a separate patch. Personally I'm a bit reluctant to having formatting options in clang-tidy at all, since that is responsibility of clang-format - then a project has duplicated settings in both tools, and it gets tricky when they get in conflict. If a project cares about formatting they would most likely have clang-format as a pre-commit check anyway to take care of formatting after clang-tidy has fixed the rest. But if people want to keep the option I won't oppose :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
