xazax.hun added a comment. I realized I did not say this explicitly in my previous comment, but feel free to commit :)
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:267 + void addFieldsReferencedInScope(llvm::DenseSet<const FieldDecl *> Fields); + ---------------- Is there any scenario where check authors might invoke this function? If no, I wonder if it would be better to make this private and make Environment a friend of this class. Keeping the number of public methods minimal could be a great service to future check authors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
