aaron.ballman added a comment. I'm not opposed to this, but it's unfortunate that this hack is broader than it needs to be because we apply this parsing logic in all circumstances, not just within a system header. However, because we already behave this way for `__is_signed`, and it seems that parsing hacks do not follow the same pattern as Sema hacks (as in https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaDeclCXX.cpp#L12523 or https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExceptionSpec.cpp#L44), this seems reasonable to me.
Do you know if folks are hitting problems here in practice, or is this speculative? The changes should have a release note for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139847/new/ https://reviews.llvm.org/D139847 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
