hokein added inline comments.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx". + For extension-less header files, using an empty string or leaving an ---------------- carlosgalvezp wrote: > Eugene.Zelenko wrote: > > ymandel wrote: > > > Eugene.Zelenko wrote: > > > > Please use single back-ticks for option values. > > > > > > > > Actually this is second patch with similar functionality during last > > > > month and I think this option should be shared between all checks. > > > Eugene -- are you suggesting that is a blocker on this patch, or just a > > > good idea for clang-tidy in general? > > Sure, it'll be better to do this as separate patch, but this should be done > > at some point. It;s both code duplication and more complex complex setup > > for users. > I'm planning to add the suggested functionality in a separate patch when I > find some time. Can fix existing checks as well. Thanks. I changed to use `,` for option values in this patch (I thought `,`, and `;` are both fine, if `,` is more preferred, we should probably change `defaultImplementationFileExtensions`, and `StringRef defaultHeaderFileExtensions` functions in `FileExtensionsUtils.h`, they use `;`, I just followed their way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140894/new/ https://reviews.llvm.org/D140894 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
