ravi-ramaseshan requested changes to this revision. ravi-ramaseshan added inline comments.
================ Comment at: clang/tools/clang-stat-cache/clang-stat-cache.cpp:28 +#include <sys/vnode.h> +#include <unistd.h> + ---------------- Some of these includes may not be available on a platform like Windows. Can you please guard them appropriately so that the build does not break? ================ Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3019 + + __attribute__((unused)) bool Consumed = Path.consume_front(BaseDir); + assert(Consumed && "Path does not start with expected prefix."); ---------------- Please use `LLVM_ATTRIBUTE_UNUSED` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
