dblaikie added inline comments.
================
Comment at: clang/include/clang/AST/PrettyPrinter.h:52
+
+ enum class TriState : int { kYes, kNo, kUnknown };
+
----------------
We don't usually use the `k` prefix for enums (the style guide mentions using
an acronym like `TS_` - though even that's unnecessary with an enum class,
where you have to use `EnumClassName` prefix anyway, so there's no issue with
ambiguity/name collisions of the enumerators)
But also, I'm guessing we probably use `std::optional<bool>` for this sort of
thing more frequently than defining a three-state enum (even though
`std::optional<bool>` can be a bit awkward to use/error prone, it's not too bad
for limited uses like this).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140423/new/
https://reviews.llvm.org/D140423
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
