erichkeane added a comment.
As far as teh fix itself, I think this is fine. BUT i think there is value in
waiting for Aaron to see if there is a deeper issue here.
================
Comment at: clang/lib/Sema/SemaInit.cpp:3863
+ SourceLocation EndLoc = VD->getEndLoc();
+ if (const auto *VTSD = dyn_cast<VarTemplateSpecializationDecl>(VD)) {
----------------
Hmm... it is strange to me that the variables 'endloc' is the end of the
identifier and not the end of the variable declaration. I unfortunately don't
have a good feeling as to the 'correct' behavior for that (Aaron is typically
the one who understands source locations better than me!), so hopefully he can
come along and see.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139705/new/
https://reviews.llvm.org/D139705
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
