craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCV.td:572
+ string default_march = "",
+ list<SubtargetFeature> tunef = []> :
ProcessorModel<n, m, f, tunef> {
+ string DefaultMarch = default_march;
----------------
80 columns
================
Comment at: llvm/lib/Target/RISCV/RISCV.td:623
+
FeatureStdExtC],
+ "rv32imafc", [TuneSiFive7]>;
+
----------------
The formatting is inconsisent. Sometimes the "rv32imafc" is on the end of the
previous line. Can we be consistent?
================
Comment at: llvm/lib/TargetParser/RISCVTargetParser.cpp:1
+//===-- TargetParser - Parser for target features ---------------*- C++
-*-===//
+//
----------------
This comment should match the name of the file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137517/new/
https://reviews.llvm.org/D137517
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
