aaron.ballman added inline comments.

================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2809
@@ +2808,3 @@
+///   matches \c foo in \c foo(t);
+AST_MATCHER_P(OverloadExpr, canReferToDecl, internal::Matcher<Decl>,
+              InnerMatcher) {
----------------
I find the name of this matcher a little bit confusing. The documentation 
doesn't describe what the matcher does (can you please clarify the docs?). The 
implementation suggests that this is looking to see if the given decl exists in 
the overload expression set, which makes me wonder why this isn't implemented 
on the `hasDeclaration()` traversal matcher rather than adding a new matcher 
name?


https://reviews.llvm.org/D23004



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to