clementval requested changes to this revision. clementval added a comment. This revision now requires changes to proceed.
You need to update the driver-help tests. ================ Comment at: flang/include/flang/Tools/CLOptions.inc:194 #if !defined(FLANG_EXCLUDE_CODEGEN) -inline void createDefaultFIRCodeGenPassPipeline(mlir::PassManager &pm) { +inline void createDefaultFIRCodeGenPassPipeline(mlir::PassManager &pm, bool Underscoring = 1) { fir::addBoxedProcedurePass(pm); ---------------- Please follow the same formatting in this file. ================ Comment at: flang/include/flang/Tools/CLOptions.inc:213 +inline void createMLIRToLLVMPassPipeline(mlir::PassManager &pm, + llvm::OptimizationLevel optLevel = defaultOptLevel, bool Underscoring = 1) { // Add default optimizer pass pipeline. ---------------- Doesn't follow the formatting here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits