arsenm added a comment.
In D138870#4020204 <https://reviews.llvm.org/D138870#4020204>, @Joe_Nash wrote:
> The code looks fine, but as you say, the change visible in user code and
> could break something. Do you want to handle that somehow? Maybe wait for
> @b-sumner
OpenMP assumes flat pointers all over, so if someone was relying on this
behavior it wasn't doing anything useful. They had dead code
================
Comment at: clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp:17
#pragma omp metadirective \
- when(device = {isa("flat-address-space")} \
+ when(device = {isa("dpp")} \
: parallel) default(single)
----------------
Joe_Nash wrote:
> Was the "dpp" attribute chosen arbitrarily?
Yes, also meaningfully varies
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138870/new/
https://reviews.llvm.org/D138870
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
