craig.topper added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5457
+ // RISC-V will handle -mcpu option in Clang::AddRISCVTargetArgs.
+ if (!Triple.isRISCV()) {
+ // Add the target cpu
----------------
kito-cheng wrote:
> craig.topper wrote:
> > I wonder if we should stop getCPUName from calling `getRISCVTargetCPU`
> > instead? Have you audited all callers of getCPUName?
> That sounds a better way, that prevent us to auditing every caller of
> `getCPUName`.
I think we need to do the audit either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140693/new/
https://reviews.llvm.org/D140693
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
