sameerds accepted this revision. sameerds added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:353 + if (HaveWave32 && HaveWave64) { + Diags.Report(diag::err_invalid_feature_combination) + << "'wavefrontsize32' and 'wavefrontsize64' are mutually exclusive"; ---------------- I would have preferred this to be a separate change, just like the FIXME for diagnosing wavefrontsize32 on targets that don't support it. But not feeling strongly enough to block this change! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits