ChuanqiXu added a comment. > My GCC patch names it -fdepfile-output= instead of --p1689-targeted-output, > gets --p1689-targeted-file-name from the regular command line (it looks like > a preprocessor command overall) and the --p1689-makeformat-output flag is > handled by the normal -MT and -MF flags. While I'm not thrilled with the > P1689 <https://reviews.llvm.org/P1689> naming in the flags (as it'll become > P2222 <https://reviews.llvm.org/P2222> once the TR it's heading for is > accepted, aliases should be simple to maintain. My GCC patch uses > -fdep-format=p1689r5 so a rename there is easier than a whole flag name. But > I suspect that clang-scan-deps is much more of a "tooling's tool" than > something people type out by hand, so it's probably not a big deal?
Agreed. I suggest to keep the current name in the process of reviewing if @jansvoboda11 don't feel unhappy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
