efriedma added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4761
+ return Opts.CPlusPlus && D->hasConstantInitialization() &&
+ D->getType()->isRecordType();
+}
----------------
Not sure what the `D->getType()->isRecordType()` check is doing here.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852
+ if (!CD->isTrivial() && !D->getTLSKind())
+ NeedsGlobalCtor = true;
+ }
----------------
I have no idea what this code is supposed to do.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5009
+ if (isStaticInit(D, getLangOpts()) && NeedsGlobalCtor && NeedsGlobalDtor) {
+ EmitCXXCtorInit(D, GV, true, 201, llvm::StringLiteral("ctor"), false);
+ EmitCXXCtorInit(D, GV, false, 65535, llvm::StringLiteral("dtor"), true);
----------------
I think you want to use priority 201 whether or not there's a destructor.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137107/new/
https://reviews.llvm.org/D137107
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
