arichardson added a comment. In D140218#4001835 <https://reviews.llvm.org/D140218#4001835>, @jdoerfert wrote:
> I don't understand why we would remove the flag for _cc_. I feel all these > patches are going exactly in the opposite direction I would think one would > go. The flag is not being removed it's just inside common.py now (see D140212 <https://reviews.llvm.org/D140212>) and defaults to on for new tests without the auto-generated note. ================ Comment at: clang/test/utils/update_cc_test_checks/Inputs/basic-cplusplus.cpp.expected:3 // Basic C++ test for update_cc_test_checks // RUN: %clang_cc1 -no-opaque-pointers -triple=x86_64-unknown-linux-gnu -emit-llvm -o - %s | FileCheck %s ---------------- arsenm wrote: > Why do we still have generated tests using -no-opaque-pointers? Surely that's > the lowest hanging fruit? Good question, I can update this as a separate NFC change on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140218/new/ https://reviews.llvm.org/D140218 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
