arsenm added a comment. In D139627#3993440 <https://reviews.llvm.org/D139627#3993440>, @arsenm wrote:
> In D139627#3983718 <https://reviews.llvm.org/D139627#3983718>, @pengfei wrote: > >>> It also doesn't mean that, because the IR doesn't have to be consistent >>> with the attribute. The IR exists independent of the attribute, and the >>> attribute can only provide performance hints. >> >> I don't agree. There are attributes like `zeroext`, `byref` are ABI related >> see https://llvm.org/docs/LangRef.html#parameter-attributes. I'd take >> `min-legal-vector-width` as a similar one. > > This is not an ABI attribute, it's an optimization hint. If it were an ABI > attribute, inferring and propagating it like is done would not be correct. If > you treat it like an optimization hint, you only have to consider this one > place instead of everywhere the IR may change Those are also parameter attributes; this is a function attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139627/new/ https://reviews.llvm.org/D139627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
