carlosgalvezp added a comment. In D139919#3991247 <https://reviews.llvm.org/D139919#3991247>, @addr2line wrote:
> Sorry, I just saw a lot of changes in the llvm repo that change > llvm::Optional to std::optional, like this one > <https://github.com/llvm/llvm-project/commit/67819a72c6ba39267effe8edfc1befddc3f3f2f9>. Interesting, then I don't know, perhaps the guidelines have changed? Would be good to get input from the other reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits