gonglingqin added a comment.
In D139915#3991089 <https://reviews.llvm.org/D139915#3991089>, @xen0n wrote:
> Linux only requires `__cpucfg` among the ones you just added. Please amend
> the patch summary so it's more accurate.
>
> Otherwise LGTM, thanks!
Thanks for your review, I will modify the summary.
================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:797
+ ASRT_LE_GT_CASE(asrtle_d)
+ ASRT_LE_GT_CASE(asrtgt_d)
+ case Intrinsic::loongarch_ldpte_d: {
----------------
xen0n wrote:
> `#undef ASRT_LE_GT_CASE` afterwards?
Thanks! I will modify it. And there are other similar problems in this file,
which I will modify later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139915/new/
https://reviews.llvm.org/D139915
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
