rengolin added inline comments.

================
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
----------------
mstorsjo wrote:
> rengolin wrote:
> > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix 
> > environments?
> I can add the same as at the top of intrin.h, i.e. this:
> 
> 
> ```
> /* Only include this if we're compiling for the windows platform. */
> #ifndef _MSC_VER
> #include_next <intrin.h>
> #else
> ```
Could be. I know you have that on the including header, but nothing stops 
people from including this one too by accident. Also, it makes it more clear 
where it should work and where it shouldn't.


https://reviews.llvm.org/D22774



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to