nridge added a comment.

While we're waiting for Sam to weigh in on the modifier question, a couple of 
comments about the details of the patch:

- Does the implementation handle explicit operator calls, e.g. 
`a.operator+(b)`? If so, it would be nice to add some test coverage.
- I see the patch handles new and delete expression but I couldn't spot any 
test cases for them, could you add some? (Apologies if I've overlooked it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136594/new/

https://reviews.llvm.org/D136594

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to