aaron.ballman added reviewers: rjmccall, efriedma.
aaron.ballman added a comment.
Adding codegen code owners in for awareness, but in general I think this is a
good cleanup. Thank you! Assuming the bots are happy, this LGTM, but please
give the codegen folks a chance to speak up before landing.
================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:140
+ static StringRef getFramePointerKindName(FramePointerKind Kind) {
+ switch (Kind) {
+ case FramePointerKind::None:
----------------
Despite this being a fully covered switch, I will not be surprised if one of
the MSVC builders gives you a diagnostic about not all paths through the
function returning a value (you may need to add an `llvm_unreachable` after the
switch to fix that).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139564/new/
https://reviews.llvm.org/D139564
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
