erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:7230 + Val && LangOpts.C2x && *Val == 0) + return false; ---------------- aaron.ballman wrote: > erichkeane wrote: > > I see below that we still set the return type of hte call to Void. Do we > > wnat to keep that line, or at least, move it to the top of this function? > I added test coverage and it seems that setting the return type is not needed > (by my understanding, `CreateBuiltin` requires the return type to be passed > to it explicitly, and `LazilyCreateBuiltin` uses the builtin type string to > specify *at least* the return type information (even if custom type checking > happens for the rest of the signature). Great, thanks for checking! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139436/new/ https://reviews.llvm.org/D139436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
