benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
Please add a comment about why this equality check is necessary.
================
Comment at: clang/lib/Lex/ModuleMap.cpp:1331
+ auto CanonicalDirEntry = FM.getDirectory(CanonicalDir);
+ if (CanonicalDirEntry && *CanonicalDirEntry == *DirEntry) {
+ bool Done = llvm::sys::path::replace_path_prefix(Path, Dir,
CanonicalDir);
----------------
Wouldn't this indicate the particular VFS has a bug?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135841/new/
https://reviews.llvm.org/D135841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
