aaron.ballman added inline comments.
================
Comment at: clang/lib/Lex/Lexer.cpp:3312
unsigned CharSize;
+
bool Diagnose = Result && !isLexingRawMode();
----------------
Spurious whitespace
================
Comment at: clang/lib/Lex/Lexer.cpp:3379
- if (LooseMatch)
+ if (LooseMatch && Diagnose)
Res = LooseMatch->CodePoint;
----------------
Why do we only want to do this if we're diagnosing?
================
Comment at: clang/lib/Lex/Lexer.cpp:3382-3384
if (Result) {
Result->setFlag(Token::HasUCN);
}
----------------
================
Comment at: clang/test/Preprocessor/ucn-pp-identifier.c:132-134
-#define CONCAT(A, B) A##B
-int CONCAT(\N{GREEK, CAPITALLETTERALPHA}); // expected-error{{expected}} \
- // expected-warning {{incomplete
delimited universal character name}}
----------------
Why did this test get removed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138861/new/
https://reviews.llvm.org/D138861
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
