hokein added a comment.
Thanks! The change is LG, I think it would be great to have some tests.
================
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:146
// to share the code?
static llvm::Optional<StringRef> parseIWYUPragma(const char *Text) {
+ // Skip the comment start, // or /*.
----------------
I'd like to have some unittests for this function (the cases you mentioned are
really good, I don't want to lose them), but this function is not exposed.
Maybe expose it or even address the FIXME?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138780/new/
https://reviews.llvm.org/D138780
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
