tmatheson added inline comments.
================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1686
-TEST(TargetParserTest, AArch64ArchFeatures) {
- std::vector<StringRef> Features;
----------------
pratlucas wrote:
> Can you keep a unit test covering the new version of the function?
The old version had special treatment for INVALID, but the new version is just
returning the feature as written in AArch64TargetParser.def. A unit test would
consist of a list of getArchFeature() calls with the same strings as in the
.def. So I could certainly add it but I'm not sure that it adds any value as a
unit test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138753/new/
https://reviews.llvm.org/D138753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
