arsenm added inline comments. Herald added subscribers: kosarev, ormris. Herald added a project: All.
================ Comment at: llvm/lib/Transforms/IPO/Annotation2Metadata.cpp:51 + auto *StrGEP = dyn_cast<ConstantExpr>(OpC->getOperand(1)); + if (!StrGEP || StrGEP->getNumOperands() < 2) + continue; ---------------- This needs to handle pure Constants / direct GlobalValue references. The test added here fails when converted to opaque pointers when all of the no-op bitcasts and getelementptrs are removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91195/new/ https://reviews.llvm.org/D91195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
