cebowleratibm added a comment.

Looks good but I just want to confirm that the profiled -L paths are appended 
in the correct order with respect to the non-profiled paths.



================
Comment at: clang/test/Driver/aix-ld.c:192
 // CHECK-LD32-GPROF:     "-lc"
+// CHECK-LD32-GPROF:     "-L[[SYSROOT]]/lib/profiled"
+// CHECK-LD32-GPROF:     "-L[[SYSROOT]]/usr/lib/profiled"
----------------
I don't currently see the test checking for the usual `/lib` and `/usr/lib` 
directories.  Should we check that the new profiled -L paths are correctly 
positioned relative to the non-profiled directories, or does it matter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137375/new/

https://reviews.llvm.org/D137375

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to