xry111 added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.h:80
void internal_sigdelset(__sanitizer_sigset_t *set, int signum);
-#if defined(__x86_64__) || defined(__mips__) || defined(__aarch64__) || \
- defined(__powerpc64__) || defined(__s390__) || defined(__i386__) || \
- defined(__arm__) || SANITIZER_RISCV64
+# if defined(__x86_64__) || defined(__mips__) || defined(__aarch64__) || \
+ defined(__powerpc64__) || defined(__s390__) || defined(__i386__) || \
----------------
SixWeining wrote:
> May be it's better to keep original indention. Otherwise the paired `#endif`
> doesn't look good.
The problem is `git clang-format` sometimes insist you to change the
indentation...
================
Comment at: compiler-rt/test/sanitizer_common/print_address.h:12
+ defined(__s390x__) || (defined(__riscv) && __riscv_xlen == 64) ||
\
+ defined(__loongarch__)
// On FreeBSD, the %p conversion specifier works as 0x%x and thus does not
----------------
SixWeining wrote:
> Should be __loongarch64?
`__loongarch64` is deprecated, use `__loongarch_lp64` instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138489/new/
https://reviews.llvm.org/D138489
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
