dblaikie added inline comments.
================ Comment at: clang/lib/Sema/SemaFixItUtils.cpp:135-140 + // Do no take address of const pointer to get void* + const PointerType *FromPtrTy = dyn_cast<PointerType>(FromQTy); + const PointerType *ToPtrTy = dyn_cast<PointerType>(ToQTy); + if (FromPtrTy && FromPtrTy->getPointeeType().isConstQualified() && + ToPtrTy->isVoidPointerType()) + return false; ---------------- Do we need to check the constness here? What other cases does it come up? Like maybe if it's volatile we'd want to do the same thing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D138426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
