kawashima-fj added a comment. In D138117#3933644 <https://reviews.llvm.org/D138117#3933644>, @zahiraam wrote:
> What I meant was that the changes about the semantic mode approx-func that > you made here https://reviews.llvm.org/D138109 , should have included the > changes that you are making in this patch about approx-func. > In general, the changes to the users' manual should be in the same patch than > the code changes. Thanks. I understand. Regarding D138109 <https://reviews.llvm.org/D138109>, the current manual already has the following sentences. > - `precise` Disables optimizations that are not value-safe on floating-point > data, although FP contraction (FMA) is enabled (`-ffp-contract=on`). This is > the default behavior. > - `strict` Enables `-frounding-math` and `-ffp-exception-behavior=strict`, > and disables contractions (FMA). All of the `-ffast-math` enablements are > disabled. Enables `STDC FENV_ACCESS`: by default `FENV_ACCESS` is disabled. > This option setting behaves as though `#pragma STDC FENV_ACESS ON` appeared > at the top of the source file. These indicates that `precise` and `strict` should disable `-fapprox-func`. D138109 <https://reviews.llvm.org/D138109> changes the code to be consistent with the manual. So D138109 <https://reviews.llvm.org/D138109> does not need to update the manual and this patch does not update the corresponding sentences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
