kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: njames93.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:66
+ llvm::cl::desc("Print the overhead of checks matching this glob"),
+ llvm::cl::init(""));
+
----------------
i guess we also need a `llvm::cl::cat(Check)` here?
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:303
+
+ for (std::string Check : listTidyChecks(CheckTidyTime)) {
+ // vlog the check name in case we crash!
----------------
nit: `StringRef` or `std::string&` or `auto`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136082/new/
https://reviews.llvm.org/D136082
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
