dcoughlin added inline comments.

================
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:509
@@ +508,3 @@
+  //    }
+  //  }
+  //}
----------------
I disagree about compactness being valuable here. I think it is more important 
to intrinsically document the spec. These will be written once and read 
frequently. When they are written, they will copied from a previous example -- 
probably by someone who is not familiar with the code or the spec format.

Another possibility (not sure if it is the right one here) is to use macro 
tricks to define a simple DSL like Kulpreet did in the LocalizationChecker.cpp.


https://reviews.llvm.org/D20811



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to