benlangmuir added inline comments.
================
Comment at: clang/lib/Serialization/ASTWriter.cpp:1561
else
// FIXME: The path should be taken from the FileEntryRef.
PP->Diag(SourceLocation(), diag::err_module_unable_to_hash_content)
----------------
jansvoboda11 wrote:
> Do you think resolving this fixme warrants separate patch?
Good catch, I'll remove this FIXME. Usually diagnostics use the on-disk path,
so I think FileEntryRef::getName is correct here and we don't need to change it
to getNameAsRequested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137989/new/
https://reviews.llvm.org/D137989
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
