sandeepkosuri added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order + : Error<"construct %0 not allowed in a region associated with a directive " ---------------- ABataev wrote: > Do you have the test for this error message? I forgot to add a test for this, I will do it. Thanks for noticing. ================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:875 + /// false - otherwise. + bool HasOrderConcurrent() const { + if (const SharingMapTy *Top = getTopOfStackOrNull()) ---------------- ABataev wrote: > `isOrderConcurrent` This function is never used, So I will remove this altogether. Thanks for pointing this out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits