v1nh1shungry added a comment.
@tom-anders Thanks for reviewing and for your suggestions!
================
Comment at: clang-tools-extra/clangd/Hover.cpp:785
+
+ // TODO: Show string literal's contents
+ HI.Name = "String Literal";
----------------
tom-anders wrote:
> Is it really useful to show the contents inside the Hover? You already see
> the contents of the string literal anyway, so I don't think this adds any
> value
I added this comment only because others show the contents. I think you're
right.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:814
+ } else {
+ // TODO: For other languages
+ return llvm::None;
----------------
tom-anders wrote:
> Hmm so what's stopping us from adding support for C here?
Because I'm not that familiar with C's data types and standards.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137650/new/
https://reviews.llvm.org/D137650
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
