cor3ntin added a comment.
Thanks for working on this.
I agree with Aaron, can you make the commit message clearer as to what is fixed,
and mention in clang/docs/ReleaseNotes that the issue is fixed.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:2698-2704
+ if (!SS.isEmpty())
+ MightBeImplicitMember = false;
+ else if (R.isOverloadedResult())
+ MightBeImplicitMember = false;
+ else if (R.isUnresolvableResult()) {
+ MightBeImplicitMember = true;
+ CheckField = false;
----------------
================
Comment at: clang/test/SemaCXX/decltype.cpp:104
+namespace GH58674 {
+ struct Foo {
----------------
I think we are reproducing the code in the issue, we should try to reproduce
all the example in that issue, including the cases that already work.
================
Comment at: clang/test/SemaCXX/decltype.cpp:116
+ void meow() {
+ using okay = decltype(Foo::value_);
+ }
----------------
Maybe we should add tests for
```
decltype(TemplateFoo<T>::value_);
decltype(Foo::nested::value);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137531/new/
https://reviews.llvm.org/D137531
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
