cor3ntin added a comment. Thanks for the review Shafik, I'll address the other comments later.
================ Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:10 + { + return undefined(); // expected-error {{not a constant expression}} \ + // expected-note {{undefined function 'undefined'}} ---------------- shafik wrote: > I don't think we expect a diagnostic here since `check_lambdas_unused` is > never called. We do because the body of a lambda is not considered a subexpression. I confirmed that with core. See https://lists.isocpp.org/core/2022/10/13364.php Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits