goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment.
In D137181#3899874 <https://reviews.llvm.org/D137181#3899874>, @MyDeveloperDay wrote: > This needs a unit test in clang/unittest/Format Fixed in V2 I think but not sure as the summary doesn't seem to have changed. ================ Comment at: clang/unittests/Format/FormatTest.cpp:5054-5056 + "#ifdef foo\n" + "#define bar() if (A) { B(); } C();\n" + "#endif", ---------------- owenpan wrote: > goldstein.w.n wrote: > > owenpan wrote: > > > You can delete them. > > Them being the ifdef/endif? If so will do for V2. > Them being lines 5054-5056. (If you mouse over the comment, the lines will be > highlighted.) Got it. Dropped in V2. ================ Comment at: clang/unittests/Format/FormatTest.cpp:5066-5068 + "#ifdef foo\n" + "#define bar() if (A) { B(); } C();\n" + "#endif", ---------------- owenpan wrote: > goldstein.w.n wrote: > > owenpan wrote: > > > Delete them or change to multiline format like lines 5048-5052. > > Delete the test of the ifndef/endif? Can do either for V2. > Actually, delete lines 5066-5068. There are mainly two ways to use > `verifyFormat`: `verifyFormat(Expected, Input, ...)` and `verifyFormat(Input, > ...)`. Here we can use the latter, in which `Input` is also expected output. Got it. Dropped in V2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137181/new/ https://reviews.llvm.org/D137181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
