cor3ntin added a comment. I think this is basically good to go, but I'll let other people give it a look too
================ Comment at: clang/lib/AST/ExprConstant.cpp:9987-9990 + } else { + llvm_unreachable( + "Expression is neither an init list nor a C++ paren list"); + } ---------------- ================ Comment at: clang/lib/CodeGen/CGExprAgg.cpp:91 + void EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, QualType ArrayQTy, + Expr *E, ArrayRef<Expr *> InitExprs); ---------------- Could you give `E` a better name? ================ Comment at: clang/lib/CodeGen/CGExprAgg.cpp:479 void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, - QualType ArrayQTy, InitListExpr *E) { - uint64_t NumInitElements = E->getNumInits(); + QualType ArrayQTy, Expr *E, + ArrayRef<Expr *> InitExprs) { ---------------- Ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits