FreddyYe added a comment.
For saving capacity of ProcessorSubtypes, gcc decided to not support part of
compiler features of these two cpus:
__builtin_cpu_is("meteorlake")
__attribute__((target("arch=raptorlake")))
... some others I don't know.
Updated to align with gcc first. Welcome opinions and review!
================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2233
+// RUN: %clang -march=raptorlake -m32 -E -dM %s -o - 2>&1 \
+// RUN: -target i386-unknown-linux \
----------------
RKSimon wrote:
> (pedantic) Probably better to put these after the alderlake tests so its
> easier to find?
I merged them with the check-prefix.
================
Comment at: compiler-rt/lib/builtins/cpu_model.c:111
+ ZHAOXIN_FAM7H_LUJIAZUI,
+ INTEL_COREI7_RAPTORLAKE,
+ INTEL_COREI7_METEORLAKE,
----------------
skan wrote:
> I see. But if possible, could we split "ZHAOXIN_FAM7H_LUJIAZUI" to another
> patch?
Related change is removed. See my latest comment.
================
Comment at: compiler-rt/lib/builtins/cpu_model.c:478
+ *Type = INTEL_COREI7;
+ *Subtype = INTEL_COREI7_METEORLAKE;
+
----------------
MaskRay wrote:
> fallthrough?
Good catch! While related changes are removed, see my latest comment.
================
Comment at: llvm/lib/Support/Host.cpp:836
+ *Type = X86::INTEL_COREI7;
+ *Subtype = X86::INTEL_COREI7_METEORLAKE;
+
----------------
MaskRay wrote:
> fallthrough?
Good catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135937/new/
https://reviews.llvm.org/D135937
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
