Author: Craig Topper Date: 2022-10-24T12:38:32-07:00 New Revision: c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7
URL: https://github.com/llvm/llvm-project/commit/c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7 DIFF: https://github.com/llvm/llvm-project/commit/c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7.diff LOG: [RISCV][clang] Support RISC-V vectors in UninitializedValues. RISC-V vectors are basically vectors, but we use builtin types to restrict the possible types. Treat them the same as vectors and scalars for this analysis. Reviewed By: reames Differential Revision: https://reviews.llvm.org/D136511 Added: clang/test/Sema/uninit-variables-riscv-vector.c Modified: clang/include/clang/AST/Type.h clang/lib/Analysis/UninitializedValues.cpp Removed: ################################################################################ diff --git a/clang/include/clang/AST/Type.h b/clang/include/clang/AST/Type.h index 4f742b99c9fea..ec980700a626a 100644 --- a/clang/include/clang/AST/Type.h +++ b/clang/include/clang/AST/Type.h @@ -2269,6 +2269,8 @@ class alignas(8) Type : public ExtQualsTypeCommonBase { /// Check if the type is the CUDA device builtin texture type. bool isCUDADeviceBuiltinTextureType() const; + bool isRVVType() const; + /// Return the implicit lifetime for this type, which must not be dependent. Qualifiers::ObjCLifetime getObjCARCImplicitLifetime() const; @@ -7201,6 +7203,14 @@ inline bool Type::isOpenCLSpecificType() const { isQueueT() || isReserveIDT() || isPipeType() || isOCLExtOpaqueType(); } +inline bool Type::isRVVType() const { +#define RVV_TYPE(Name, Id, SingletonId) \ + isSpecificBuiltinType(BuiltinType::Id) || + return +#include "clang/Basic/RISCVVTypes.def" + false; // end of boolean or operation. +} + inline bool Type::isTemplateTypeParmType() const { return isa<TemplateTypeParmType>(CanonicalType); } diff --git a/clang/lib/Analysis/UninitializedValues.cpp b/clang/lib/Analysis/UninitializedValues.cpp index 7f44685355e08..8f9230c5805c6 100644 --- a/clang/lib/Analysis/UninitializedValues.cpp +++ b/clang/lib/Analysis/UninitializedValues.cpp @@ -46,7 +46,8 @@ static bool isTrackedVar(const VarDecl *vd, const DeclContext *dc) { !vd->isExceptionVariable() && !vd->isInitCapture() && !vd->isImplicit() && vd->getDeclContext() == dc) { QualType ty = vd->getType(); - return ty->isScalarType() || ty->isVectorType() || ty->isRecordType(); + return ty->isScalarType() || ty->isVectorType() || ty->isRecordType() || + ty->isRVVType(); } return false; } diff --git a/clang/test/Sema/uninit-variables-riscv-vector.c b/clang/test/Sema/uninit-variables-riscv-vector.c new file mode 100644 index 0000000000000..0f91b0d75710b --- /dev/null +++ b/clang/test/Sema/uninit-variables-riscv-vector.c @@ -0,0 +1,14 @@ +// RUN: %clang_cc1 -triple riscv64 -fsyntax-only -Wuninitialized -fsyntax-only -target-feature +v %s -verify + +#pragma clang riscv intrinsic vector + +void test1(int *input, long vl) { + __rvv_int32m1_t x, y, z, w, X; // expected-note {{variable 'x' is declared here}} expected-note {{variable 'y' is declared here}} expected-note {{variable 'w' is declared here}} expected-note {{variable 'z' is declared here}} + x = vxor_vv_i32m1(x,x, vl); // expected-warning {{variable 'x' is uninitialized when used here}} + y = vxor_vv_i32m1(y,y, vl); // expected-warning {{variable 'y' is uninitialized when used here}} + z = vxor_vv_i32m1(z,z, vl); // expected-warning {{variable 'z' is uninitialized when used here}} + w = vxor_vv_i32m1(w,w, vl); // expected-warning {{variable 'w' is uninitialized when used here}} + X = vle32_v_i32m1(&input[0], vl); + X = vxor_vv_i32m1(X,X, vl); // no-warning +} + _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
