mgorny added inline comments.
================ Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) ---------------- nickdesaulniers wrote: > Seems error prone. Does cmake have an include system for including fragments > from elsewhere? If so, that seems like a more concise and less error prone > approach. > > https://cmake.org/cmake/help/latest/command/include.html I suppose that makes sense. I think that at this point all these components require the top-level `cmake` directory from monorepo anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
